-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
logSink: revert defaultBufferChanSize, add a trigger to flush logSink.units when chennal is full (#2431) #2444
logSink: revert defaultBufferChanSize, add a trigger to flush logSink.units when chennal is full (#2431) #2444
Conversation
….units when chennal is full (pingcap#2431)
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 3ba9b5b
|
/run-integration-tests |
/run-kafka-tests |
2 similar comments
/run-kafka-tests |
/run-kafka-tests |
This is an automated cherry-pick of #2431
What problem does this PR solve?
1259 2424
What is changed and how it works?
Recover
defaultBufferChanSize
to 20480 which increased by 1469.Add a criterion for refreshing logSink.units, which
sendEvents.Load() == defaultBufferChanSize
, i.e. units chennal is full.Check List
Tests
Code changes
Side effects
Related changes
Release note